[GraphQL] Make id field optional for custom mutations

[lukasluecke]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#2736
License	MIT
Doc PR	-

All other mutations (except create) get an optional id field to allow different kinds of custom mutations.

[lukasluecke]

@alanpoulain What do you think? (test failure seems to be unrelated)

Probably should be in 2.4 and not master, but I'll leave that up to you 🙈

[alanpoulain]

I think we should have a Behat test for this feature.

[lukasluecke]

I will try to add the test later today 🙂

[lukasluecke]

@alanpoulain I added a simple test for this change 🙂

[lukasluecke]

@alanpoulain @dunglas I rebased this onto the newest changes again, could we maybe get this merged?

Some tests seem to be failing for some unrelated reason, the others I will look into shortly.

[alanpoulain]

I'm not sure about this one. Now you can define your own arguments for your custom mutation.
By default the ID is required but you can remove or make it optional it if you want.

[lukasluecke]

I don't think that the current possibilities for custom arguments are really "usable" for this, as I'd have to re-define all arguments just to get rid of the required ID. However if you think that the way forward would be better custom arguments, I'll try to work on that instead (might take a little longer though) 🙂

[kacperjurak]

Hello, is it possible to merge this change? I really need overwrite create mutation in my project.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.