-
-
Notifications
You must be signed in to change notification settings - Fork 918
Normalize non-resource objects in a standalone normalizer #2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
soyuka
merged 2 commits into
api-platform:2.4
from
teohhanhui:fix/normalize-non-resource
Apr 6, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,190 @@ | ||
| Feature: GraphQL DTO input and output | ||
| In order to use a hypermedia API | ||
| As a client software developer | ||
| I need to be able to use DTOs on my resources as Input or Output objects. | ||
|
|
||
| @createSchema | ||
| Scenario: Retrieve an Output with GraphQl | ||
| When I add "Content-Type" header equal to "application/ld+json" | ||
| And I send a "POST" request to "/dummy_dto_input_outputs" with body: | ||
| """ | ||
| { | ||
| "foo": "test", | ||
| "bar": 1 | ||
| } | ||
| """ | ||
| Then the response status code should be 201 | ||
| And the JSON should be equal to: | ||
| """ | ||
| { | ||
| "@context": { | ||
| "@vocab": "http://example.com/docs.jsonld#", | ||
| "hydra": "http://www.w3.org/ns/hydra/core#", | ||
| "id": "OutputDto/id", | ||
| "baz": "OutputDto/baz", | ||
| "bat": "OutputDto/bat" | ||
| }, | ||
| "@type": "DummyDtoInputOutput", | ||
| "@id": "/dummy_dto_input_outputs/1", | ||
| "id": 1, | ||
| "baz": 1, | ||
| "bat": "test" | ||
| } | ||
| """ | ||
| When I send the following GraphQL request: | ||
| """ | ||
| { | ||
| dummyDtoInputOutput(id: "/dummy_dto_input_outputs/1") { | ||
| _id, id, baz | ||
| } | ||
| } | ||
| """ | ||
| Then the response status code should be 200 | ||
| And the response should be in JSON | ||
| And the header "Content-Type" should be equal to "application/json" | ||
| And the JSON should be equal to: | ||
| """ | ||
| { | ||
| "data": { | ||
| "dummyDtoInputOutput": { | ||
| "_id": 1, | ||
| "id": "/dummy_dto_input_outputs/1", | ||
| "baz": 1 | ||
| } | ||
| } | ||
| } | ||
| """ | ||
|
|
||
| Scenario: Create an item using custom inputClass & disabled outputClass | ||
| Given there are 2 dummyDtoNoOutput objects | ||
| When I send the following GraphQL request: | ||
| """ | ||
| mutation { | ||
| createDummyDtoNoOutput(input: {foo: "A new one", bar: 3, clientMutationId: "myId"}) { | ||
| dummyDtoNoOutput { | ||
| id | ||
| } | ||
| clientMutationId | ||
| } | ||
| } | ||
| """ | ||
| Then the response status code should be 200 | ||
| And the response should be in JSON | ||
| And the header "Content-Type" should be equal to "application/json" | ||
| And the JSON should be equal to: | ||
| """ | ||
| { | ||
| "errors": [ | ||
| { | ||
| "message": "Cannot query field \"id\" on type \"DummyDtoNoOutput\".", | ||
| "extensions": { | ||
| "category": "graphql" | ||
| }, | ||
| "locations": [ | ||
| { | ||
| "line": 4, | ||
| "column": 7 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| """ | ||
|
|
||
| Scenario: Cannot create an item with input fields using disabled inputClass | ||
| When I send the following GraphQL request: | ||
| """ | ||
| mutation { | ||
| createDummyDtoNoInput(input: {lorem: "A new one", ipsum: 3, clientMutationId: "myId"}) { | ||
| clientMutationId | ||
| } | ||
| } | ||
| """ | ||
| Then the response status code should be 200 | ||
| And the response should be in JSON | ||
| And the header "Content-Type" should be equal to "application/json" | ||
| And the JSON should be equal to: | ||
| """ | ||
| { | ||
| "errors": [ | ||
| { | ||
| "message": "Field \"lorem\" is not defined by type createDummyDtoNoInputInput.", | ||
| "extensions": { | ||
| "category": "graphql" | ||
| }, | ||
| "locations": [ | ||
| { | ||
| "line": 2, | ||
| "column": 33 | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "message": "Field \"ipsum\" is not defined by type createDummyDtoNoInputInput.", | ||
| "extensions": { | ||
| "category": "graphql" | ||
| }, | ||
| "locations": [ | ||
| { | ||
| "line": 2, | ||
| "column": 53 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| """ | ||
|
|
||
| Scenario: Create an item with empty input fields using disabled inputClass (no persist done) | ||
| When I send the following GraphQL request: | ||
| """ | ||
| mutation { | ||
| createDummyDtoNoInput(input: {clientMutationId: "myId"}) { | ||
| dummyDtoNoInput { | ||
| id | ||
| } | ||
| clientMutationId | ||
| } | ||
| } | ||
| """ | ||
| Then the response status code should be 200 | ||
| And the response should be in JSON | ||
| And the header "Content-Type" should be equal to "application/json" | ||
| And the JSON should be equal to: | ||
| """ | ||
| { | ||
| "data": { | ||
| "createDummyDtoNoInput": { | ||
| "dummyDtoNoInput": null, | ||
| "clientMutationId": "myId" | ||
| } | ||
| } | ||
| } | ||
| """ | ||
|
|
||
| @!mongodb | ||
| Scenario: Use messenger with graphql and an input where the handler gives a synchronous result | ||
| When I send the following GraphQL request: | ||
| """ | ||
| mutation { | ||
| createMessengerWithInput(input: {var: "test"}) { | ||
| messengerWithInput { id, name } | ||
| } | ||
| } | ||
| """ | ||
| Then the response status code should be 200 | ||
| And the response should be in JSON | ||
| And the header "Content-Type" should be equal to "application/json" | ||
| And the JSON should be equal to: | ||
| """ | ||
| { | ||
| "data": { | ||
| "createMessengerWithInput": { | ||
| "messengerWithInput": { | ||
| "id": "/messenger_with_inputs/1", | ||
| "name": "test" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.