Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions phpstan.neon.dist
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ parameters:
-
message: '#Cannot assign offset .+ to bool\.#'
path: %currentWorkingDirectory%/src/GraphQl/Resolver/FieldsToAttributesTrait.php
-
message: '#Access to an undefined property GraphQL\\Language\\AST\\ValueNode::\$value\.#'
path: %currentWorkingDirectory%/src/GraphQl/Type/Definition/IterableType.php
- '#Access to an undefined property Prophecy\\Prophecy\\ObjectProphecy<(\\?[a-zA-Z0-9_]+)+>::\$[a-zA-Z0-9_]+#'
- '#Call to an undefined method Doctrine\\Common\\Persistence\\ObjectManager::getConnection\(\)#'
- '#Parameter \#1 \$function of function call_user_func expects callable\(\): mixed, .+ given\.#'
Expand All @@ -56,6 +53,15 @@ parameters:
-
message: '#Parameter \#1 \$collection of method ApiPlatform\\Core\\Tests\\GraphQl\\Resolver\\Factory\\CollectionResolverFactoryTest::createCollectionResolverFactory\(\) expects array\|Iterator, object given\.#'
path: %currentWorkingDirectory%/tests/GraphQl/Resolver/Factory/CollectionResolverFactoryTest.php
-
message: '#Parameter \#1 \$resourceClass of method ApiPlatform\\Core\\Metadata\\Property\\Factory\\InheritedPropertyMetadataFactory::create\(\) expects string, object\|string given\.#'
path: %currentWorkingDirectory%/src/Metadata/Property/Factory/InheritedPropertyMetadataFactory.php
-
message: '#Parameter \#1 \$childInherited of method ApiPlatform\\Core\\Metadata\\Property\\PropertyMetadata::withChildInherited\(\) expects string, object\|string given\.#'
path: %currentWorkingDirectory%/src/Metadata/Property/Factory/InheritedPropertyMetadataFactory.php
-
message: '#Parameter \#1 \$resourceClass of method ApiPlatform\\Core\\Metadata\\Property\\Factory\\InheritedPropertyNameCollectionFactory::create\(\) expects string, object\|string given\.#'
path: %currentWorkingDirectory%/src/Metadata/Property/Factory/InheritedPropertyNameCollectionFactory.php
-
message: '#Property ApiPlatform\\Core\\Test\\DoctrineMongoDbOdmFilterTestCase::\$repository \(Doctrine\\ODM\\MongoDB\\Repository\\DocumentRepository\) does not accept Doctrine\\ORM\\EntityRepository<ApiPlatform\\Core\\Tests\\Fixtures\\TestBundle\\Document\\Dummy>\.#'
path: %currentWorkingDirectory%/src/Test/DoctrineMongoDbOdmFilterTestCase.php
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
*/
final class InheritedPropertyMetadataFactory implements PropertyMetadataFactoryInterface
{
private $resourceNameCollection;
private $resourceNameCollectionFactory;
private $decorated;

public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollection, PropertyMetadataFactoryInterface $decorated = null)
public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, PropertyMetadataFactoryInterface $decorated = null)
{
$this->resourceNameCollection = $resourceNameCollection;
$this->resourceNameCollectionFactory = $resourceNameCollectionFactory;
$this->decorated = $decorated;
}

Expand All @@ -39,7 +39,7 @@ public function create(string $resourceClass, string $property, array $options =
{
$propertyMetadata = $this->decorated ? $this->decorated->create($resourceClass, $property, $options) : new PropertyMetadata();

foreach ($this->resourceNameCollection->create() as $knownResourceClass) {
foreach ($this->resourceNameCollectionFactory->create() as $knownResourceClass) {
if ($resourceClass === $knownResourceClass) {
continue;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
*/
final class InheritedPropertyNameCollectionFactory implements PropertyNameCollectionFactoryInterface
{
private $resourceNameCollection;
private $resourceNameCollectionFactory;
private $decorated;

public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollection, PropertyNameCollectionFactoryInterface $decorated = null)
public function __construct(ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory, PropertyNameCollectionFactoryInterface $decorated = null)
{
$this->resourceNameCollection = $resourceNameCollection;
$this->resourceNameCollectionFactory = $resourceNameCollectionFactory;
$this->decorated = $decorated;
}

Expand All @@ -46,7 +46,7 @@ public function create(string $resourceClass, array $options = []): PropertyName
}
}

foreach ($this->resourceNameCollection->create() as $knownResourceClass) {
foreach ($this->resourceNameCollectionFactory->create() as $knownResourceClass) {
if ($resourceClass === $knownResourceClass) {
continue;
}
Expand Down
6 changes: 4 additions & 2 deletions src/Metadata/Resource/ResourceNameCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,18 @@ public function __construct(array $classes = [])

/**
* {@inheritdoc}
*
* @return \Traversable<string>
*/
public function getIterator()
public function getIterator(): \Traversable
{
return new \ArrayIterator($this->classes);
}

/**
* {@inheritdoc}
*/
public function count()
public function count(): int
{
return \count($this->classes);
}
Expand Down