Skip to content

Comments

Add a cache warmer to clear cache pools in dev#2650

Merged
soyuka merged 2 commits intoapi-platform:2.4from
teohhanhui:fix/metadata-cache-in-dev
Mar 26, 2019
Merged

Add a cache warmer to clear cache pools in dev#2650
soyuka merged 2 commits intoapi-platform:2.4from
teohhanhui:fix/metadata-cache-in-dev

Conversation

@teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Mar 26, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets alternative fix for #2644, reverts the revert #2648, partially #2593
License MIT
Doc PR api-platform/docs#772

Note: Does not really warm the cache (lol)

Does not really warm the cache (lol)
@teohhanhui teohhanhui force-pushed the fix/metadata-cache-in-dev branch from d47f200 to b8d22f8 Compare March 26, 2019 00:38
@teohhanhui
Copy link
Contributor Author

teohhanhui commented Mar 26, 2019

phpstan errors are unrelated, caused by https://github.com/phpstan/phpstan/releases/tag/0.11.5

Update: See #2651

@soyuka
Copy link
Member

soyuka commented Mar 26, 2019

We could call the resourceMetadata chain to warm it up though :p

@soyuka soyuka merged commit 2c7a861 into api-platform:2.4 Mar 26, 2019
@teohhanhui teohhanhui deleted the fix/metadata-cache-in-dev branch March 26, 2019 11:17
@nicolas-grekas
Copy link
Contributor

Will be part of Symfony 5.1, see symfony/symfony#35109
Too bad is hasn't be submitted on Symfony before, it would have made it to 4.4/5.0
Anyway, cool idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants