-
-
Notifications
You must be signed in to change notification settings - Fork 920
Remove a BC break introduced by #2243 #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meyerbaptiste
commented
Mar 22, 2019
Q | A |
---|---|
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | yes |
Tests pass? | yes |
Fixed tickets | n/a |
License | MIT |
Doc PR | n/a |
Huum, there is also a BC break in the constructor and more difficult to handle because of the last argument |
What’s the problem with the constructor? We should mark these class @Final. |
We cannot change a non-final class to final. That would be a BC break. Edit: Uhh, you mean the annotation. |
We can add the |
This should target |
The regression is only in master @teohhanhui |
7f761a6
to
ce7dfd4
Compare
I just added the BC for the constructor @api-platform/core-team. |
ce7dfd4
to
8e1ee34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a PHPStan false positive exclusion