Add tests on the debug bar/profiler view#2314
Conversation
tests/Metadata/Property/Factory/AnnotationPropertyNameCollectionFactoryTest.php
Outdated
Show resolved
Hide resolved
|
@dunglas I'll need help to understand why appveyor run trigger deprecation warning. I suspected that LEGACY env var is set and tried to skip tests based on this but doesn't seems to work. EDIT: most of those composer.json might have to target 2.3 🤔 ? |
|
I got appveyor build to pass, just waiting for chocaltey to be up... |
7f35d11 to
204c10c
Compare
3041b1d to
023f4b1
Compare
|
rebase and merge conflict resolved. May we merge ? |
appveyor.yml
Outdated
|
|
||
| test_script: | ||
| - cd %APPVEYOR_BUILD_FOLDER% | ||
| - php tests\Fixtures\app\console cache:clear |
There was a problem hiding this comment.
Why is it necessary? The cache should not be populated by default.
There was a problem hiding this comment.
I wish I know the real reason... Both suites works without issue independently but when they are run without clearing the cache, in the second suite NelmioApiDocBundle was enabled for now real reason and trigger deprecation notices. (Enabling the NelmioApiDocBundle integration has been deprecated in 2.2 and will be removed in 3.0. NelmioApiDocBundle 3 has native support for API Platform.)
I've been fighting with this for a while on appveyor and finally looked at travis config
Lines 45 to 53 in 7dbd207
It might be related to the way that I'm booting the kernel for the test...
😞
appveyor.yml
Outdated
| - cd %APPVEYOR_BUILD_FOLDER% | ||
| - php tests\Fixtures\app\console cache:clear | ||
| - php vendor\behat\behat\bin\behat --format=progress --suite=default | ||
| - php tests\Fixtures\app\console cache:clear |
6f4f1ea to
c37e2b4
Compare
7114526 to
75e0fbb
Compare
75e0fbb to
a656df5
Compare
a656df5 to
df072bc
Compare
35007f3 to
297319e
Compare
update tests to support lowest dependencies Avoid deprecation errors when booting kernel with NelmioApiDocBundle (try to fix appveyor)
297319e to
24d4c28
Compare
09ae888 to
745668e
Compare
745668e to
bc66927
Compare
|
Thank you @antograssiot! |
The idea is to prevent me or someone else to break the debug bar again 😅
I would totally understand if this is not merged though
ref #2307