Add a non regression test for #2285 #2286#2291
Merged
dunglas merged 1 commit intoapi-platform:2.3from Nov 1, 2018
Merged
Conversation
antograssiot
force-pushed
the
non-regression-test
branch
4 times, most recently
from
f74050e to
a3790e3
Compare
dunglas
reviewed
Oct 30, 2018
| mkdir -p build/logs/tmp build/cov | ||
| for f in $(find features -name '*.feature' -not -path 'features/main/exposed_state.feature' | circleci tests split --split-by=timings); do | ||
| _f=${f//\//_} | ||
| FEATURE="${_f}" phpdbg -qrr vendor/bin/behat --profile=coverage --suite=default --tags=~@postgres --format=progress --out=std --format=junit --out=build/logs/tmp/"${_f}" "$f" |
Member
There was a problem hiding this comment.
(It's probably this change that decreases the coverage)
Contributor
Author
There was a problem hiding this comment.
The coverage was already decreasing before this change.
I just saw that it was useless as the tags are defined in the behat.yml.dist
that's basically what I did a while ago, see 71e37cb
I can revert if you prefer
dunglas
reviewed
Oct 30, 2018
| vendor/bin/behat --suite=default --format=progress; | ||
| fi | ||
| - tests/Fixtures/app/console api:swagger:export > swagger.json && npx swagger-cli validate swagger.json && rm swagger.json | ||
| - tests/Fixtures/app/console api:swagger:export --yaml > swagger.yaml && npx swagger-cli validate --no-schema swagger.yaml && rm swagger.yaml |
Contributor
Author
There was a problem hiding this comment.
This option is not needed anymore has the generated file is compliant 🤷♂️
before schema validation was failling @dunglas
antograssiot
force-pushed
the
non-regression-test
branch
from
a3790e3 to
d76ac70
Compare
Member
|
Thanks @antograssiot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: Adding test decrease coverage... of course 😈