Bump PHPStan analysis to level 6#2272
Merged
dunglas merged 2 commits intoapi-platform:2.3from Oct 30, 2018
Merged
Conversation
antograssiot
force-pushed
the
phpstan-level6
branch
from
89ee481 to
7ab3d48
Compare
soyuka
reviewed
Oct 24, 2018
Member
soyuka
left a comment
soyuka
left a comment
There was a problem hiding this comment.
Can we move some casts on the variable assignation instead of where we're using it?
| $placeholder = $queryNameGenerator->generateParameterName($key); | ||
| $qb->andWhere("$alias.$key = :$placeholder"); | ||
| $topQueryBuilder->setParameter($placeholder, $value, $classMetadata->getTypeOfField($key)); | ||
| $topQueryBuilder->setParameter($placeholder, $value, (string) $classMetadata->getTypeOfField($key)); |
Member
There was a problem hiding this comment.
Suggested change
| $topQueryBuilder->setParameter($placeholder, $value, (string) $classMetadata->getTypeOfField($key)); | |
| $topQueryBuilder->setParameter($placeholder, $value, (string) $classMetadata->getTypeOfField($key)); |
| ); | ||
| } else { | ||
| $output->writeln($content); | ||
| $output->writeln((string) $content); |
Member
There was a problem hiding this comment.
why do we have to cast here? Maybe that we should cast above in the variable declaration?
Contributor
Author
There was a problem hiding this comment.
that was because of the json_encode that could return false but I've corrected in a "cleaner" way I think
| $keyName = array_keys($matches[$rootName])[0]; | ||
|
|
||
| $queryParameter = $request->query->get($rootName); | ||
| $queryParameter = $request->query->get((string) $rootName); |
antograssiot
changed the title
antograssiot
commented
Oct 24, 2018
antograssiot
changed the title
antograssiot
force-pushed
the
phpstan-level6
branch
from
66725b7 to
d4b7360
Compare
soyuka
approved these changes
Oct 25, 2018
antograssiot
force-pushed
the
phpstan-level6
branch
2 times, most recently
from
3bc38f1 to
a303384
Compare
antograssiot
force-pushed
the
phpstan-level6
branch
from
a303384 to
7373d47
Compare
Contributor
Author
|
I've solved the merge conflicts and rebased, anything left to be done here ? |
Member
|
Thanks @antograssiot! |
cr3a7ure
added a commit
to cr3a7ure/core
that referenced
this pull request
Nov 5, 2018
* ApiPlatformExtension cleanup * Remove a now useless composer hack * remove unset attributes key in normalization context * Add tests on doctrine collection purge * Fix 2285 - force Yaml::dump to dump empty array as actual empty array * improve graphiql CSS * Prefix root resource route_prefix to sub-resources Unit test also added * Bump PHPStan analysis to level 6 (api-platform#2272) * Bump PHPStan analysis to level 6 * Bump PHPStan analysis to level 6 * Bump PHPStan analysis to level 6 * Deprecate dead code in QueryJoinParser and remove internal usage * Add a non regression test for api-platform#2285 api-platform#2286 * Ability to modify response headers (mainly cache related headers) (api-platform#2288) * Allow user-defined cache headers A user may wish to define response cache headers in a custom controller or per resource. E.g. a /entity/random endpoint should have a max-age of 0 * Override cache max-age and shared-max-age Add annotation attributes for cache_headers which allows max_age and shared_max_age to be assigned per resource. * Remove unused property The property was added when I thought it may be good to have the option outside of 'attributes' - decided to put the option in attributes instead and failed to remove this property. * Code style fixes * Test code style fix * Review changes applied - Order of constructor arguments + default null value - Remove 'throws' annotation - setting $resourceCacheHeaders with default fallback to empty array - Improved conditional statements * Add cacheHeaders Attribute annotation * Accidental typo * Alphabetical order Updated attribute annotation to alphabetical order - moved the property into alphabetical order as well * Add data providers and data persisters matches to the debug panel (api-platform#2262) * Add data providers and data persisters matches to the debug panel * Add tests on traceable providers and persisters * Use internal public properties * Merge config file and add tests on Extension * Avoid extra loop in data persister/providers * remove duplicated code * Fix after rebasing * Allow an input and an output for a given resource class * [Bugfix] Remove type Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #2267 (comment)