Allow multiple order filters in entity.#2230
Merged
soyuka merged 1 commit intoapi-platform:2.3from Nov 2, 2018
Merged
Conversation
Member
|
👍 missing some cs fixes though |
Contributor
Author
|
@soyuka looks like I missed one space character somehow and the code is not aligned. I will deploy a fix little later. |
Contributor
Author
|
@soyuka , please review and let me know. |
soyuka
approved these changes
Oct 4, 2018
Member
|
Perfect thanks, we just need to change the base branch to 2.3 because it's a bug fix! |
Member
|
Could you do the rebase please @Siregacvek? |
soyuka
force-pushed
the
multiple-order-filters
branch
from
9ab1629 to
eccc92e
Compare
Member
|
I rebased. |
soyuka
force-pushed
the
multiple-order-filters
branch
from
eccc92e to
3e4818b
Compare
Member
|
Thanks @Siregacvek ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improvement allows to have several orderFilters in one entity.
I faced a problem when I created my own custom Order Filter. As a result in the same class I use 2 different order filters: default and my custom (which extends default). But Api-Platform can't handle several order filters - only last one wins. This commit fixes this issue.