Fix allow_failures on Travis CI #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teohhanhui
commented
Jul 16, 2018
teohhanhui
commented
| Q | A |
|---|---|
| Bug fix? | yes (CI) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
teohhanhui
commented
Jul 16, 2018
| @@ -11,7 +11,7 @@ env: | |||
| - SYMFONY_DEPRECATIONS_HELPER=weak_vendors | |||
| - APP_ENV=test | |||
|
|
|||
| matrix: | |||
| jobs: | |||
There was a problem hiding this comment.
Minor future-proofing:
matrixis an alias ofjobs
travis-ci/travis-ci#7754 (comment)
Travis CI docs are outdated: travis-ci/docs-travis-ci-com#1500 (comment)
teohhanhui
force-pushed
the
fix/travis-allow-failures
branch
from
48a07a1 to
aad9c6b
Compare
teohhanhui
commented
Jul 16, 2018
| @@ -32,7 +32,8 @@ matrix: | |||
| - mysql -e 'CREATE DATABASE api_platform_test;' | |||
| env: APP_ENV=mysql | |||
| allow_failures: | |||
| env: SYMFONY_DEPRECATIONS_HELPER=0 | |||
| - env: SYMFONY_DEPRECATIONS_HELPER=0 | |||
| fast_finish: true | |||
There was a problem hiding this comment.
Doesn't seem to have any effect at the moment... lol
|
Thanks @teohhanhui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.