Skip to content

Fix tests for symfony > 3.4.12 symfony/27467 #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix tests for symfony > 3.4.12 symfony/27467 #2047

wants to merge 1 commit into from

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Jun 26, 2018

teohhanhui
teohhanhui suggested changes Jun 26, 2018
View reviewed changes
tests/Fixtures/app/AppKernel.php
@@ -110,12 +110,9 @@ protected function configureContainer(ContainerBuilder $c, LoaderInterface $load
'default' => [
'provider' => 'chain_provider',
'http_basic' => null,
'anonymous' => null,
'anonymous' => true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS: missing trailing comma

tests/Fixtures/app/AppKernel.php
'access_control' => [
['path' => '^/', 'role' => 'IS_AUTHENTICATED_ANONYMOUSLY'],
],
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS: missing trailing comma

@teohhanhui
Copy link
Contributor

Since we can't fix it, shall we mark that specific test as skipped?

@dunglas dunglas mentioned this pull request Jun 28, 2018
Merged
@soyuka soyuka closed this Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teohhanhui teohhanhui teohhanhui requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soyuka @teohhanhui