Allow subresource items in the iri converter #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohhanhui
reviewed
May 2, 2018
| @@ -58,6 +58,7 @@ | |||
| <argument type="service" id="api_platform.router" /> | |||
| <argument type="service" id="api_platform.property_accessor" /> | |||
| <argument type="service" id="api_platform.identifiers_extractor.cached" /> | |||
| <argument type="service" id="api_platform.subresource_data_provider" oninvalid="ignore" /> | |||
soyuka
force-pushed
the
allow-subresource-iri-bis
branch
3 times, most recently
from
d6a6157 to
52e9098
Compare
|
Guess what I like coverage. |
soyuka
force-pushed
the
allow-subresource-iri-bis
branch
from
52e9098 to
6d40a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1877
Had to
rewritecopy/paste the code 😄This needs a PR after the merge on master though, some things have been improved.