Simplify boolean filter

[bendavies]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

no need for extra query builder named parameters here. just use $expr->literal(...)

[teohhanhui]

This has implications for the DBMS prepared statement, no? I don't see why we'd want to do this, to be honest. Does it give a sizeable performance gain?

[bendavies]

The reason i did this because

1. there is no need for the parameter.
2. the sql produced by symfonys profiler is invalid before this change, (at least for postgres - it produces where field = 1/0 which is wrong)

[teohhanhui]

That's a Symfony profiler bug.

[soyuka]

Isn't doctrine storing booleans as integers anyway?

[teohhanhui]

Isn't doctrine storing booleans as integers anyway?

No. Not on PostgreSQL at least. The integers 0 and 1 are not valid boolean values: https://www.postgresql.org/docs/9.1/static/datatype-boolean.html

https://github.com/doctrine/dbal/blob/v2.7.1/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php#L66-L86

[bendavies]

@teohhanhui

That's a Symfony profiler bug.

Well yes that's stating the obvious. I still don't understand the objection.

Cheers

[teohhanhui]

I'm against it because a value is a value, not a literal. If there's a sizeable performance gain, I'm okay with making exceptions for the rule. But otherwise, I don't see why we'd do that.