EagerLoadingExtension: respect fetchEager=false on an association #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -170,14 +170,13 @@ private function joinRelations(QueryBuilder $queryBuilder, QueryNameGeneratorInt | |||
| $inAttributes = null; | |||
| } | |||
|
|
|||
| $fetchEager = $propertyMetadata->getAttribute('fetchEager'); | |||
| if (false === $fetchEager) { | |||
soyuka
approved these changes
Apr 26, 2018
Simperfit
approved these changes
Apr 27, 2018
|
Thank you @bendavies |
teohhanhui
pushed a commit
to teohhanhui/api-platform-core
that referenced
this pull request
May 2, 2018
…force-eager EagerLoadingExtension: respect fetchEager=false on an association
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forceEager/fetchEagerdoes not already result in a performance boost, so being able to disable it per association is crucial.This:
Was not being respected, and ignored if the association was
readableor areadableLink.@dunglas I don't really understand the
ifstatement that this PR fixes, specifically the variable$inAttributes.You introduced it here: #1552. I'd be grateful if you could check this over and explain the
if?Thanks