Skip to content

fix exists filter #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2018
Merged

fix exists filter #1861

merged 1 commit into from
Apr 19, 2018

Conversation

IonBazan
Copy link
Contributor

@IonBazan IonBazan commented Apr 13, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #1857
License MIT
Doc PR -

It still requires tests fixes. I will try to solve that later. Fixed.

@soyuka
Copy link
Member

soyuka commented Apr 13, 2018

ping @alanpoulain

@alanpoulain
Copy link
Member

It seems the filter cannot be used for description. Another bug?

@IonBazan
Copy link
Contributor Author

IonBazan commented Apr 14, 2018

@alanpoulain I think it is due to filters order. There is search, order and exists filter for description field and the mapping for GraphQL does not support that 😞 I think we could create another issue for that but it requires confirmation.

@alanpoulain
Copy link
Member

I see. Yes I think we need to open another issue for that.

@IonBazan
Copy link
Contributor Author

Ping @dunglas please review.

@IonBazan IonBazan changed the base branch from master to 2.2 April 18, 2018 13:39
@IonBazan
Copy link
Contributor Author

@soyuka @dunglas I've squashed the commits and changed PR base onto 2.2.

}
"""
Then the response status code should be 200
Then the JSON node "data.dummies.edges" should have 2 elements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And

@soyuka soyuka merged commit 885bda2 into api-platform:2.2 Apr 19, 2018
@soyuka
Copy link
Member

soyuka commented Apr 19, 2018

Thanks @IonBazan !

@IonBazan IonBazan deleted the exists-fix branch April 19, 2018 09:12
teohhanhui pushed a commit to teohhanhui/api-platform-core that referenced this pull request May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants