Backport #1725 into 2.2 branch. #1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zarthus
changed the title
soyuka
approved these changes
Apr 9, 2018
Simperfit
approved these changes
Apr 9, 2018
|
Please wait for @dunglas approval for this not sure he agrees that this should be backported. |
|
Aye, this is just a convenience PR because we had to do the work for our own regardless. (we currently run this in our testing environments and confirm it functions as expected) |
meyerbaptiste
approved these changes
Apr 9, 2018
There was a problem hiding this comment.
Approved by @lenancker too! This will allow us to remove Brigade on 2.2.
|
To clarify, we usually never merge new features (as this one) in the current branch, but merging this one will allow to reduce dramatically the bill of our Kubernetes cluster (and our carbon footprint btw). It's the only reason why we do an exception. Thanks @Zarthus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports issue #1725 onto the 2.2 branch.
closes #1818
Directly cherry picked from commit 52a3a32.