Avoid to call OrderFilter on wrong properties #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Jan 24, 2018
| @@ -79,6 +79,7 @@ public function __construct(ManagerRegistry $managerRegistry, RequestStack $requ | |||
| public function apply(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null, array $context = []) | |||
| { | |||
| if (!isset($context['filters'][$this->orderParameterName]) || !\is_array($context['filters'][$this->orderParameterName])) { | |||
| $context['filters'] = null; | |||
There was a problem hiding this comment.
looks hackish no? Any other way we could fix that?
There was a problem hiding this comment.
My first though @soyuka was to remove the call to parent::apply() but it was breaking phpunit test suite. The issue to solve here is to call the grand parent function without calling the parent function.
To be more explicit, in this if we would need to call AbstractFilter::apply()
without calling AbstractContextAwareFilter::apply(), this is the way I found.
There was a problem hiding this comment.
Mhh yeah ok I think I got it. LGTM then thanks and nice catch btw!
dunglas
approved these changes
Jan 29, 2018
sroze
approved these changes
Jan 29, 2018
|
I've just rebased this (it's a master fix because context['filters'] was introduced there). Merging when status 🍏 |
|
thanks @antograssiot |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Avoid to call OrderFilter on wrong properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2.2-beta-1 if a order filter and let say a date filter are declared on the same property (
createdAt), then calling/dummies?createdAt[before]=2018-01-24will trigger the date filter and cause aType error: strtoupper() expects parameter 1 to be string, array given in vendor/api-platform/core/src/Bridge/Doctrine/Orm/Filter/OrderFilter.php:134