Closed
Conversation
Contributor
vincentchalamon
commented
Jan 8, 2018
vincentchalamon
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #1580 (comment) |
| License | MIT |
| Doc PR |
Member
|
It's only failing on master? |
Contributor
Author
|
@soyuka I don't think so. |
Member
Yes |
vincentchalamon
force-pushed
the
master
branch
from
8ca922d to
cd4f3f5
Compare
Contributor
Author
|
@soyuka It's rebased on 2.0 |
Member
|
still failing with some deprecations :| |
Contributor
Author
|
@soyuka Those deprecations are out of this PR scope. Was it working earlier? Should I target it on 2.1? |
dunglas
requested changes
Jan 8, 2018
| { | ||
| $request = new Request(); | ||
|
|
||
| $requestProphecy = $this->prophesize(Request::class); |
Member
There was a problem hiding this comment.
Objects (without related interfaces) from external libraries should not be mocked, especially when its a value object like this one.
Merged
Member
|
Thanks @vincentchalamon, fixed in #1634. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.