Trigger eager loading when using the attributes serializer option #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
eager-load-attributes
branch
from
132741a to
748782b
Compare
dunglas
force-pushed
the
eager-load-attributes
branch
from
748782b to
fe80ac4
Compare
Simperfit
approved these changes
Dec 6, 2017
| unset($context[AbstractNormalizer::ATTRIBUTES]); | ||
| } | ||
|
|
||
| if ( |
soyuka
reviewed
Dec 6, 2017
|
|
||
| if ( | ||
| ((!$inAttributes && false === $propertyMetadata->isReadableLink()) || false === $propertyMetadata->isReadable()) && | ||
| false === $propertyMetadata->getAttribute('fetchEager', false) |
There was a problem hiding this comment.
false === $propertyMetadata->getAttribute('fetchEager', false) should not be needed here as it should've been tested https://github.com/dunglas/core/blob/master/src/Bridge/Doctrine/Orm/Extension/EagerLoadingExtension.php#L142
Did you start you PR on master? I can't recognize the replaced code which may have lead to weird copy/paste?
There was a problem hiding this comment.
Can I let you handle that? I've changed this part (only the CS) and I'm not really comfortable with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: