Skip to content

Comments

Fix request auto-runner#1456

Merged
dunglas merged 1 commit into2.1from
fix-swaggerui
Oct 23, 2017
Merged

Fix request auto-runner#1456
dunglas merged 1 commit into2.1from
fix-swaggerui

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Oct 23, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

This feature was broken since an update of SwaggerUI... Please be careful when updating Swagger UI.

@soyuka
Copy link
Member

soyuka commented Oct 23, 2017

Please be careful when updating Swagger UI.

Meaning? Who updated/merged it? How can we avoid this?

@meyerbaptiste
Copy link
Member

Who updated/merged it?

Me: #1330 😃

@dunglas
Copy link
Member Author

dunglas commented Oct 23, 2017

@soyuka We could introduce a functional test but it will require to add a WebDriver implementation... And our build will be still slower.

Instead, I think to propose to the Swagger UI team to add this feature upstream.

@dunglas
Copy link
Member Author

dunglas commented Oct 23, 2017

During the meantime, the solution is to test manually when runing ./update-js.sh

@dunglas dunglas merged commit e2ef9c6 into 2.1 Oct 23, 2017
@dunglas dunglas deleted the fix-swaggerui branch October 23, 2017 19:36
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants