Merged
Conversation
Member
meyerbaptiste
commented
Oct 17, 2017
meyerbaptiste
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
- Remove deprecations
- Remove dead code
- Clean PHPDoc
- Various fixes
meyerbaptiste
force-pushed
the
fix_phpunit_2.0
branch
3 times, most recently
from
c6b0a16 to
1b6ad88
Compare
dunglas
approved these changes
Oct 18, 2017
soyuka
approved these changes
Oct 19, 2017
Member
|
😠 should've let you rebase, hate the github button -_- |
meyerbaptiste
force-pushed
the
fix_phpunit_2.0
branch
from
0a06b35 to
a99eabc
Compare
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
Clean PHPUnit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.