Reuse PriorityTaggedServiceTrait from symfony#1412
Closed
norkunas wants to merge 1 commit intoapi-platform:2.0from
Closed
Reuse PriorityTaggedServiceTrait from symfony#1412norkunas wants to merge 1 commit intoapi-platform:2.0from
norkunas wants to merge 1 commit intoapi-platform:2.0from
Conversation
norkunas
force-pushed
the
simplify-compilerpass
branch
2 times, most recently
from
9ce1477 to
1a0bc4d
Compare
norkunas
force-pushed
the
simplify-compilerpass
branch
from
1a0bc4d to
041fb19
Compare
Contributor
Author
|
Oh.. dependency injection component is a soft dependency :/ |
Member
|
But we can update our method with the one provided by the Symfony trait... |
Contributor
Author
|
If you want I can submit PR for that |
Member
|
Definitely @norkunas! |
Contributor
|
When using this compiler pass we know what the DependencyInjection component is here tho... so we could use this trait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only difference will be now that it will throw if service will be abstract, but I think this should have done already before.