[2.1] Allow to specify a whitelist of properties for Property Filter #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
approved these changes
Aug 29, 2017
soyuka
requested changes
Aug 29, 2017
There was a problem hiding this comment.
1) tests/Serializer/Filter/PropertyFilterTest.php
---------- begin diff ----------
--- Original
+++ New
@@ @@
- $propertyFilter = new PropertyFilter('properties', false, ['foo', 'group' =>['baz' => ['qux']]]);
+ $propertyFilter = new PropertyFilter('properties', false, ['foo', 'group' => ['baz' => ['qux']]]);
$propertyFilter->apply($request, true, [], $context);
- $this->assertEquals(['attributes' => ['qux', 'foo', 'group' =>['baz' => ['qux']]]], $context);
+ $this->assertEquals(['attributes' => ['qux', 'foo', 'group' => ['baz' => ['qux']]]], $context);
meyerbaptiste
approved these changes
Aug 29, 2017
antograssiot
force-pushed
the
property-filter-whitelist
branch
from
5799407 to
82ea3b7
Compare
|
@soyuka the CS issue should be fixed |
soyuka
approved these changes
Aug 29, 2017
|
Thanks @antograssiot |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…r-whitelist [2.1] Allow to specify a whitelist of properties for Property Filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1333 but for the property filter. Doc PR will follow in the week for both PR