Move the metadata from validator factory to the validator.xml file#1113
Merged
dunglas merged 1 commit intoapi-platform:2.0from May 15, 2017
Merged
Move the metadata from validator factory to the validator.xml file#1113dunglas merged 1 commit intoapi-platform:2.0from
dunglas merged 1 commit intoapi-platform:2.0from
Conversation
meyerbaptiste
approved these changes
May 15, 2017
Simperfit
approved these changes
May 15, 2017
Member
|
Hmm phpstan errors are not related. I'll fix those in another patch. They may be the consequence of a phpstan upgrade. |
Member
|
@sroze you can rebase if you want, should fix phpstan :) |
Member
|
IMO you should change the base branch to |
Member
|
Btw, the API pack includes the validator: https://github.com/api-platform/api-pack/blob/master/composer.json#L17 Anyway this PR must be merged. |
sroze
force-pushed
the
move-the-validator-metadata
branch
from
ed8f685 to
52a4509
Compare
Contributor
Author
|
Rebased and targeted on 2.0 😉 |
Member
|
Thank you @sroze! |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…tadata Move the metadata from validator factory to the validator.xml file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the validator as a dev dependency, it won't necessary be installed when using ApiPlatform's "pack" and Symfony Flex. Still, the validator is a dependency to get the metadata from its component: moving this definition to the
validator.xmlfile that is only included when the validator component exists fixes the problem.