Issues found on 2.7

[vincentchalamon]

Write here as comment the errors you may found on api-platform/core:2.7.x-dev installed on your project. Please mention:

• the error message
• the related code if possible
• the service declaration, if specified
• the PHP version
• the Symfony version
• a fix proposal, if possible

[vincentchalamon]

• PHP 8.0.14
• Symfony 5.3.*

TypeError: App\Core\Api\IriConverter::__construct(): Argument #1 ($decorated) must be of type ApiPlatform\Core\Api\IriConverterInterface, ApiPlatform\Symfony\Routing\IriConverter given

# src/Core/Api/IriConverter.php
use ApiPlatform\Core\Api\IriConverterInterface;

final class IriConverter implements IriConverterInterface
{
    public function __construct(private IriConverterInterface $decorated)
    {
    }
}

App\Core\Api\IriConverter:
    decorates: api_platform.iri_converter

Bug: api_platform.symfony.iri_converter decorates api_platform.iri_converter.legacy which breaks the backward compatibility.
Fix: api_platform.symfony.iri_converter should not decorate api_platform.iri_converter.legacy but inject it as an argument.

[vincentchalamon]

• PHP 8.0.14
• Symfony 5.3.*

In deprecation.php line 483:
Warning: Undefined array key "ApiPlatform\Core\Serializer\SerializerContextBuilderInterface"

Command executed: bin/console debug:event kernel.request -vvv

Fix: replace $deprecatedClasses by $deprecatedInterfaces in deprecation.php line 483

[vincentchalamon]

• PHP 8.0.14
• Symfony 5.3.*

Cannot retrieve collection operation attribute:

$operationName = $request->attributes->get('_api_collection_operation_name'); // api_broadcast_programmings_get_collection
$resourceMetadata->getCollectionOperationAttribute($operationName, 'filters_expression'); // null

Collection operations:

array:1 [
  "get" => array:9 [
    "repository_method" => "getCollection"
    "filters_expression" => "request.query.get('segment') and (request.query.get('noEmiarte') or (request.query.get('intervalStartAt') and request.query.get('intervalEndAt')))"
    "filters_message" => "Query parameter "segment" is required with "noEmiarte" or "intervalEndAt" and "scenario"."
    "input" => null
    "output" => null
    "method" => "GET"
    "stateless" => null
    "input_formats" => array:4 [
      "jsonld" => array:1 [
        0 => "application/ld+json"
      ]
      "json" => array:1 [
        0 => "application/json"
      ]
      "html" => array:1 [
        0 => "text/html"
      ]
      "csv" => array:1 [
        0 => "text/csv"
      ]
    ]
    "output_formats" => array:4 [
      "jsonld" => array:1 [
        0 => "application/ld+json"
      ]
      "json" => array:1 [
        0 => "application/json"
      ]
      "html" => array:1 [
        0 => "text/html"
      ]
      "csv" => array:1 [
        0 => "text/csv"
      ]
    ]
  ]
]

Bug: invalid collection operation name, got get instead of api_broadcast_programmings_get_collection (or the contrary)

[vincentchalamon]

• PHP 8.0.14
• Symfony 5.3.*

HTTP 400 invalid filters error message has changed from "detail": "..." to "hydra:description": "..."

[vincentchalamon]

• PHP 8.0.14
• Symfony 5.3.*

TypeError: Arte\Data\Bridge\ApiPlatform\DataProvider\Extension\PaginationExtension::__construct(): Argument #1 ($pagination) must be of type ApiPlatform\Core\DataProvider\Pagination, ApiPlatform\State\Pagination\Pagination given

# vendor/arte/data-bundle/src/Bridge/ApiPlatform/DataProvider/Extension/PaginationExtension.php
use ApiPlatform\Core\DataProvider\Pagination;

final class PaginationExtension implements CollectionExtensionInterface, ResultCollectionExtensionInterface

<service id="arte_data.api_platform.extension.pagination" class="Arte\Data\Bridge\ApiPlatform\DataProvider\Extension\PaginationExtension" public="false">
    <argument type="service" id="api_platform.pagination"/>

    <tag name="arte_data.api_platform.collection_extension" priority="-1"/>
</service>

[vincentchalamon]

• PHP 8.0.14
• Symfony 5.3.*

ApiPlatform\Exception\InvalidArgumentException: The filter class "Arte\Data\Bridge\ApiPlatform\DataProvider\Extension\Filter\SearchFilter" does not implement "ApiPlatform\Api\FilterInterface". Did you forget a use statement?

namespace Arte\Data\Bridge\ApiPlatform\DataProvider\Extension\Filter;

use ApiPlatform\Core\Api\FilterInterface as ApiFilterInterface;

interface FilterInterface extends ApiFilterInterface

[vincentchalamon]

PHP Fatal error: Cannot declare class ApiPlatform\State\Pagination\Pagination, because the name is already in use in /path/to/vendor/api-platform/core/src/Core/DataProvider/Pagination.php on line 29

[vincentchalamon]

You have requested a non-existent service "api_platform.doctrine.orm.metadata.property.metadata_factory"

Replace ApiPlatformExtension.php:873 by the following:

if ($this->isConfigEnabled($container, $config['doctrine'])) {
    $remapDefinitionClasses['api_platform.doctrine.orm.metadata.property.metadata_factory'] = 'ApiPlatform\Core\Bridge\Doctrine\Orm\Metadata\Property\DoctrineOrmPropertyMetadataFactory';
}

[vincentchalamon]

You have requested a non-existent service "api_platform.metadata.property.metadata_factory.legacy".

Remove api_platform.metadata.property.metadata_factory.xml from $remapDefinitionClasses in ApiPlatformExtension.php, and add the following before the $remapDefinitionClasses declaration:

$container->getDefinition('api_platform.metadata.property.metadata_factory.xml')->setClass('ApiPlatform\Core\Metadata\Property\Factory\ExtractorPropertyMetadataFactory');
$container->setAlias('api_platform.metadata.property.metadata_factory.legacy', 'api_platform.metadata.property.metadata_factory.xml');

[vincentchalamon]

PHP Fatal error: During class fetch: Uncaught ReflectionException: Class "ApiPlatform\Core\Cache\CachedTrait" not found while loading "ApiPlatform\Core\Metadata\Property\Factory\CachedPropertyMetadataFactory".

Replace ApiPlatform\Core\Cache\CachedTrait by ApiPlatform\Util\CachedTrait in CachedPropertyMetadataFactory.php.

[vincentchalamon]

Attempted to load class "PropertyInfoPropertyMetadataFactory" from namespace "ApiPlatform\Metadata\Property".
Did you forget a "use" statement for "ApiPlatform\Core\Bridge\Symfony\PropertyInfo\Metadata\Property\PropertyInfoPropertyMetadataFactory"?

Replace namespace ApiPlatform\Metadata\Property by ApiPlatform\Metadata\Property\Factory in PropertyInfoPropertyMetadataFactory.php.

[vincentchalamon]

ApiPlatform\Core\Metadata\Property\Factory\ExtractorPropertyMetadataFactory::__construct(): Argument #1 ($extractor) must be of type ApiPlatform\Core\Metadata\Extractor\ExtractorInterface, ApiPlatform\Core\Metadata\Extractor\XmlExtractor given

Create ExtractorInterface.php as following:

interface ExtractorInterface extends ResourceExtractorInterface

...and implement it in legacy XmlExtractor and YamlExtractor.

[vincentchalamon]

Replace api_platform.property.metadata_factory by api_platform.metadata.property.metadata_factory in ApiPlatformExtension.php

[vincentchalamon]

ApiPlatform\Core\Metadata\Property\Factory\AnnotationPropertyMetadataFactory::__construct(): Argument #2 ($decorated) must be of type ?ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface, ApiPlatform\Metadata\Property\Factory\PropertyInfoPropertyMetadataFactory given

Related service: api_platform.metadata.property.identifier_metadata_factory.annotation
Replace ApiPlatformExtension.php:852-856 with the following code:

        $remapDefinitionDecorations = [
            'api_platform.metadata.property.identifier_metadata_factory.xml',
            'api_platform.metadata.property.identifier_metadata_factory.yaml',
            'api_platform.metadata.property.identifier_metadata_factory.annotation',
        ];

        foreach ($remapDefinitionDecorations as $definition) {
            $container->getDefinition($definition)->setDecoratedService('api_platform.metadata.property.metadata_factory');
        }