chore: Update dependencies (security), improve CI workflow #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
J3m5
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies to address security vulnerabilities while refining the CI workflow and lint configuration. Key changes include:
- Updating the "brace-expansion" dependency to v2.0.2.
- Reorganizing and adding new CI steps (formatting check, type checking, and improved naming) for better feedback.
- Updating Prettier usage with the experimental CLI and adapting linting rules via .oxlintrc.json.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/getResources.ts | Simplified arrow function syntax for filtering resource paths. |
| src/swagger/handleJson.ts | Reordered imports and updated arrow function syntax for field mapping. |
| src/hydra/fetchJsonLd.test.ts | Converted test mocks to concise arrow functions for improved clarity. |
| pnpm-workspace.yaml | Added overrides for "brace-expansion" dependency as part of the update. |
| package.json | Updated dependency versions and enhanced Prettier CLI usage. |
| .prettierignore | Added pnpm lock and workspace files to the ignore list. |
| .oxlintrc.json | Introduced additional ESLint rules and adjustments per updated guidelines. |
| .github/workflows/ci.yml | Reorganized CI steps and renamed steps for clearer workflow indications. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
J3m5
force-pushed
the
chore/update-deps
branch
2 times, most recently
from
c39220c to
962d7d8
Compare
- Replace `Build` step by `Check types`. - Adjusted the order of `Check types` to follow `Lint`. Signed-off-by: J3m5 <5523410+J3m5@users.noreply.github.com>
- Updated brace-expansion from 2.0.1 to 2.0.2 in both pnpm-lock.yaml and pnpm-workspace.yaml - Added overrides for brace-expansion in pnpm-workspace.yaml Vulnerability report: GHSA-v6h2-p8h4-qcjw Patched release: https://github.com/juliangruber/brace-expansion/releases/tag/v2.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies to address security issues and refines the CI workflow
Summary of changes:
brace-expansionto v2.0.2 to fix a security vulnerability--experimental-clifor faster formatting and added.prettierignore