Merge pull request laravel#104 from laravel/symfony5

[3.x] Prepare 3.0 release

.gitattributes

@@ -1,8 +1,12 @@
 * text=auto
 
 /.github export-ignore
+/tests export-ignore
+/tests-output export-ignore
 .editorconfig export-ignore
 .gitattributes export-ignore
 .gitignore export-ignore
 .styleci.yml export-ignore
+.travis.yml export-ignore
 CHANGELOG.md export-ignore
+phpunit.xml.dist export-ignore

.gitignore

@@ -1,2 +1,4 @@
 /vendor
 composer.lock
+phpunit.xml
+.phpunit.result.cache

.travis.yml

@@ -0,0 +1,14 @@
+language: php
+
+php:
+  - 7.2
+  - 7.3
+
+sudo: false
+
+before_install:
+  - phpenv config-rm xdebug.ini || true
+
+install: travis_retry composer install --no-interaction --prefer-dist
+
+script: vendor/bin/phpunit --verbose

composer.json

@@ -9,19 +9,38 @@
             "email": "taylorotwell@gmail.com"
         }
     ],
+    "require": {
+        "php": "^7.2",
+        "ext-zip": "*",
+        "guzzlehttp/guzzle": "^6.0",
+        "symfony/console": "^4.0|^5.0",
+        "symfony/filesystem": "^4.0|^5.0",
+        "symfony/process": "^4.0|^5.0"
+    },
+    "require-dev": {
+        "phpunit/phpunit": "^8.0"
+    },
+    "bin": [
+        "bin/laravel"
+    ],
     "autoload": {
         "psr-4": {
             "Laravel\\Installer\\Console\\": "src/"
         }
     },
-    "require": {
-        "ext-zip": "*",
-        "guzzlehttp/guzzle": "~6.0",
-        "symfony/console": "~3.0|~4.0",
-        "symfony/filesystem": "~3.0|~4.0",
-        "symfony/process": "~3.0|~4.0"
+    "autoload-dev": {
+        "psr-4": {
+            "Laravel\\Installer\\Console\\Tests\\": "tests/"
+        }
     },
-    "bin": [
-        "laravel"
-    ]
+    "extra": {
+        "branch-alias": {
+            "dev-master": "3.x-dev"
+        }
+    },
+    "config": {
+        "sort-packages": true
+    },
+    "minimum-stability": "dev",
+    "prefer-stable": true
 }

phpunit.xml.dist

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit backupGlobals="false"
+         backupStaticAttributes="false"
+         beStrictAboutTestsThatDoNotTestAnything="false"
+         bootstrap="vendor/autoload.php"
+         colors="true"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         processIsolation="false"
+         stopOnError="false"
+         stopOnFailure="false"
+         verbose="true"
+>
+    <testsuites>
+        <testsuite name="Laravel Installer Test Suite">
+            <directory suffix="Test.php">./tests</directory>
+            <exclude>./tests/scaffolds</exclude>
+        </testsuite>
+    </testsuites>
+    <filter>
+        <whitelist processUncoveredFilesFromWhitelist="true">
+            <directory suffix=".php">./src</directory>
+        </whitelist>
+    </filter>
+</phpunit>

src/NewCommand.php

@@ -37,7 +37,7 @@ protected function configure()
      *
      * @param  \Symfony\Component\Console\Input\InputInterface  $input
      * @param  \Symfony\Component\Console\Output\OutputInterface  $output
-     * @return void
+     * @return int
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
@@ -81,7 +81,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }, $commands);
         }
 
-        $process = new Process(implode(' && ', $commands), $directory, null, null, null);
+        $process = Process::fromShellCommandline(implode(' && ', $commands), $directory, null, null, null);
 
         if ('\\' !== DIRECTORY_SEPARATOR && file_exists('/dev/tty') && is_readable('/dev/tty')) {
             $process->setTty(true);
@@ -94,6 +94,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if ($process->isSuccessful()) {
             $output->writeln('<comment>Application ready! Build something amazing.</comment>');
         }
+
+        return 0;
     }
 
     /**

tests-output/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

tests/NewCommandTest.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Laravel\Installer\Console\Tests;
+
+use Laravel\Installer\Console\NewCommand;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Console\Application;
+use Symfony\Component\Console\Tester\CommandTester;
+use Symfony\Component\Filesystem\Filesystem;
+
+class NewCommandTest extends TestCase
+{
+    public function test_it_can_scaffold_a_new_laravel_app()
+    {
+        $scaffoldDirectoryName = 'tests-output/my-app';
+        $scaffoldDirectory = __DIR__.'/../'.$scaffoldDirectoryName;
+
+        if (file_exists($scaffoldDirectory)) {
+            (new Filesystem)->remove($scaffoldDirectory);
+        }
+
+        $app = new Application('Laravel Installer');
+        $app->add(new NewCommand);
+
+        $tester = new CommandTester($app->find('new'));
+
+        $statusCode = $tester->execute(['name' => $scaffoldDirectoryName, '--auth' => null]);
+
+        $this->assertEquals($statusCode, 0);
+        $this->assertDirectoryExists($scaffoldDirectory.'/vendor');
+        $this->assertFileExists($scaffoldDirectory.'/.env');
+        $this->assertFileExists($scaffoldDirectory.'/resources/views/auth/login.blade.php');
+    }
+}