Skip to content

Conversation

@ian-fox
Copy link
Contributor

@ian-fox ian-fox commented Jul 24, 2023

  • Update contributing.md to reflect the change from poetry to setuptools
  • Add attrs as a dependency in pyproject.toml

Attrs is imported in structures.py but is not actually installed by default. It appears to be some transitive dependency of one of the dev dependencies, so it works fine if you install in dev mode but if you're installing the package without that you got an import error.

I thought this was small enough that it wasn't worth adding a test in the suite for, but if you disagree please let me know and I can add one.

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (42473ae) 94.78% compared to head (e724e13) 94.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          32       32           
  Lines        1974     1974           
=======================================
  Hits         1871     1871           
  Misses        103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percevalw
Copy link
Member

percevalw commented Jul 31, 2023

Hi ! thanks for this, could you rebase against the latest commit of main? That should fix the documentation check

Copy link
Member

@percevalw percevalw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also left a few suggestions

ian-fox and others added 4 commits August 1, 2023 14:33
Co-authored-by: Perceval Wajsburt <perceval.wajsburt@gmail.com>
Co-authored-by: Perceval Wajsburt <perceval.wajsburt@gmail.com>
@ian-fox
Copy link
Contributor Author

ian-fox commented Aug 1, 2023

Thanks for the feedback, applied both and rebased!

@percevalw percevalw merged commit 492db04 into aphp:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants