-
Notifications
You must be signed in to change notification settings - Fork 6
future/fixed: update fixed-point implementation to match latest lib.fixed
RFC
#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror on matrix test?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.fixed
RFC.lib.fixed
and make sure it interacts with the rest of Amaranth and my existing DSP components without unexpected surprises.lib.fixed
is added out-of-tree underamaranth_future.fixed
, so we can still point to upstream Amaranth releases.lib.fixed
that is now run againstamaranth_future.fixed
.tiliqua.dsp
, now fixed bylib.fixed
.Memory
instances that were initialized by normalValue
when they could be initialized byfixed.Value
.dsp.Boxcar
implementation to usedelay_line
, and move it todelay
.DCBlock
DSP component and use it inpolysyn
.DCBlock
.SVF
/MatrixMix
to reduce noise and DC bias.