-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that events defined in chart options are called too. #105
Conversation
Has this been released yet ? I'm working with "apexcharts": "^3.49.2" and "vue3-apexcharts": "^1.5.3" and it seems to not be there yet ? |
This is yet to be released. |
@junedchhipa any updates on a new release for this? Just ran into this exact issue. |
released vue3-apexcharts@v1.6.0 |
This commit has caused many regressions in v1.6.0 which is now unstable. |
released |
@junedchhipa Release v1.7.0 did not address the issue introduced in this commit. Both versions 1.6.0 and 1.7.0 now contain this regression. I would suggest reverting the entirety of changes in v1.6.0 until these can be regression tested against all issues below, which remain unresolved.
|
My changes did not introduce any issues. If you revert the config event change and keep my changes everything works fine. |
Currently vue3-apexcharts defines the same callback for each of apexcharts events, and those callbacks just calls "emit()" so that the e.g.
@mousemove='some-handler'
-style definition works:vue3-apexcharts/src/vue3-apexcharts.js
Lines 137 to 138 in 02b0a1a
But the docs don't mention this limitation anywhere, so most people unsuccessfully define events in the chart options like the apexcharts docs describe.
This fix calls any defined events in the chart options after the
emit()
is called, so the chart options' events will work.fix #20