Fixing unnecessary chart destroy on create #4970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing to destroy the chart on create
After this commit, the
ApexChartdoesn't work withTabsproperly. I made a demonstration setup about the issue with Vue and Quasar frameworks:https://codepen.io/siczmj/pen/vEYxBxL
You can see that the
ApexChartappears on first rendering, but it disappears after tab switching. To reproduce it click on "Second" then on "First" tab. My investigation showed that this is caused by the invokeddestroy()method added by the linked commit.By removing the
this.destroy()it looks good to me.Type of change
Please delete options that are not relevant.
Checklist: