Skip to content

Conversation

@siczmj
Copy link
Contributor

@siczmj siczmj commented Mar 2, 2025

Preventing to destroy the chart on create

After this commit, the ApexChart doesn't work with Tabs properly. I made a demonstration setup about the issue with Vue and Quasar frameworks:
https://codepen.io/siczmj/pen/vEYxBxL

You can see that the ApexChart appears on first rendering, but it disappears after tab switching. To reproduce it click on "Second" then on "First" tab. My investigation showed that this is caused by the invoked destroy() method added by the linked commit.

By removing the this.destroy() it looks good to me.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@junedchhipa junedchhipa merged commit a06fa04 into apexcharts:main Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants