Remove use of global ApexCharts class
#4884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
The
setupBrushHandlermethod of theCoreclass relies on theApexChartsclass' staticgetChartByIDmethod. It calls this static method on theApexChartsclass directly without importing it currently.This is fine if consuming
apexchartsviaCDN / script tag as that places the exported
ApexChartsclass in the global scope, but it becomes an issue when users want to consumeapexchartsvia a package manager.Update the
setupBrushHandlermethod to callApexCharts.getChartByIDtheCoreclass'ctxfield instead.Fixes apexcharts/react-apexcharts#666
Type of change
Checklist:
getBBox is not a functionerror when I run them, which I can see has been occurring in yourNode.js CIaction. I'm not sure if that's related to the browser API or one of your internal utils but let me know if you want me to rebase / merge changes in once that's fixed and run the unit tests.