Fix a potential crash condition when collapsing series' #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simply use w.globals.min and w.globals.max because the user may have configured one or both as a function, which can cause those global values to be poor substitutes causing undefined behaviour. Substitute sane default values in that case.
junedchhipa
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in a previous PR.
In Scales.niceScale() when the passed-in yMin and yMax indicate no data, cannot simply substitute w.globals.min and w.globals.max as the user may have configured one or both as a function, making it likely that the global min/max values are not suitable and which can cause undefined behaviour. Substitute sane default values in that case.
Type of change
Please delete options that are not relevant.