Skip to content

Conversation

@Avladd
Copy link

@Avladd Avladd commented Dec 20, 2023

New Pull Request

Fixes x-axis generating an incorrect hourly scale when using a full starting hour.

This previous merge introduced this bug because the incrementation for the hour was changed outside the if statement but not inside.

Fixes #4111 and this

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Avladd
Copy link
Author

Avladd commented Dec 20, 2023

For reviewers: I have intentionally not squashed commits for you to more easily test the existing bug. Run the unit tests added in the first commit to see them failing, and then compare to solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong hours on x-axis labels if dataset starts at round hours

2 participants