Skip to content

fix: detect positioning for leftmost values #4004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: detect positioning for leftmost values #4004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions src/modules/tooltip/Utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,11 @@ export default class Utils {

let capturedSeries = null
let closest = null
let seriesXValArr = []
let seriesYValArr = []

//add extra values to show markers for the first points. Included both axes to avoid incorrect positioning of the marker
w.globals.seriesXvalues.forEach((value) => {
seriesXValArr.push([value[0] + 0.000001].concat(value))
})
w.globals.seriesYvalues.forEach((value) => {
seriesYValArr.push([value[0] + 0.000001].concat(value))
})

seriesXValArr = seriesXValArr.map((seriesXVal) => {
let seriesXValArr = seriesXValArr.map((seriesXVal) => {
return seriesXVal.filter((s) => Utilities.isNumber(s))
})
seriesYValArr = seriesYValArr.map((seriesYVal) => {
let seriesYValArr = seriesYValArr.map((seriesYVal) => {
return seriesYVal.filter((s) => Utilities.isNumber(s))
})

Expand Down Expand Up @@ -155,7 +145,7 @@ export default class Utils {
Xarrays.forEach((arrX) => {
arrX.forEach((x, iX) => {
const newDiff = Math.abs(hoverX - x)
if (newDiff < diffX) {
if (newDiff <= diffX) {
diffX = newDiff
j = iX
}
Expand All @@ -170,7 +160,7 @@ export default class Utils {

Yarrays.forEach((arrY, iAY) => {
const newDiff = Math.abs(hoverY - arrY[j])
if (newDiff < diffY) {
if (newDiff <= diffY) {
diffY = newDiff
currIndex = iAY
}
Expand Down