Skip to content

Conversation

@consvic
Copy link
Contributor

@consvic consvic commented Sep 8, 2023

New Pull Request

The documentation shows that colorStops is an array of objects but the types have them as any.

Would be nice to have the types here when overriding the stops of a gradient.

Docs:https://apexcharts.com/docs/options/fill/

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit edff060 into apexcharts:main Sep 9, 2023
@consvic consvic deleted the colorOptions-types branch September 11, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants