Skip to content

Add ability to use gradient fill on line and area at the same time #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022
Merged

Add ability to use gradient fill on line and area at the same time #3122

merged 1 commit into from
May 2, 2022

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Apr 29, 2022

New Pull Request

Adds the ability to have both line and area paths fillable with a gradient (and any other fill option).

1651256622

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@lf94
Copy link
Contributor Author

lf94 commented Apr 29, 2022

@junedchhipa letting you know this is quite important for us (alephium/explorer#89 (comment)) (https://github.com/alephium). I'll do anything that's necessary to get this as quickly merged and published. 🙂

@junedchhipa junedchhipa merged commit 67efa47 into apexcharts:main May 2, 2022
@lf94
Copy link
Contributor Author

lf94 commented May 2, 2022

Wow thank you, that was quite fast! I truly appreciate it.

@lf94
Copy link
Contributor Author

lf94 commented May 2, 2022

For what it's worth, I didn't included the built files in dist/. I wasn't sure about it.

@junedchhipa
Copy link
Contributor

@lf94 The dist folder shouldn't be included. It will be generated when a new version is released.

@junedchhipa
Copy link
Contributor

@lf94 Can you please share the configuration to generate the chart you attached in the screenshot?
That's a beautiful design and will go into our "popular" Codepen collections to show our users how to generate such gradients in an area chart.

@lf94
Copy link
Contributor Author

lf94 commented May 8, 2022

Yeah! It's here: https://github.com/alephium/explorer/pull/91/files#diff-699e44cfab97aa2e9c65b3463d19450b50cd00907df9da4f5f256fb0d95bcec6R90

Thank you so much again for being quick with the merge...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants