Skip to content

Conversation

@jliit
Copy link
Contributor

@jliit jliit commented Mar 2, 2021

Adds BOM to CSV export

The exported CSV-file is missing a byte order mark (BOM). This causes Excel to misinterpret the file and gets the encoding wrong. This PR adds a BOM to the beginning of the CSV-file.

Fixes #1629

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit 03a876c into apexcharts:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encoding in a csv document

2 participants