Skip to content

Conversation

@YtGz
Copy link
Contributor

@YtGz YtGz commented May 15, 2020

New Pull Request

Adds a property named 'startAngle' that determines where pie or donut charts start drawing.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Adds a property named 'startAngle' that determines where the chart starts drawing.
@junedchhipa junedchhipa merged commit 624abcc into apexcharts:master May 16, 2020
@junedchhipa
Copy link
Contributor

Thank you! Looks good.

@junedchhipa
Copy link
Contributor

junedchhipa commented May 16, 2020

Single value pie/donut charts don't work with this.

For eg.,

var options = {
  series: [10],
  chart: {
    type: 'donut',
    width: 380
  },
  plotOptions: {
    pie: {
      startAngle: 180
    }
  },
  labels: ['Team A']
}

This should draw a full circle.

@junedchhipa
Copy link
Contributor

Removing % this.fullAngle from endAngle and prevEndAngle in the commit above fixed it.
I hope that doesn't break other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants