Skip to content

Conversation

@wolfeidau
Copy link
Contributor

@wolfeidau wolfeidau commented Jan 24, 2018

The original code returned base64 content when https://github.com/gin-gonic/gin provided the following mime type application/json; charset=utf-8 for JSON.

This fix works based on my testing, interested to hear your thoughts on using the inbuilt mime package for parsing.

  • Changed matching to allow for trailing encoding.
  • Added a test case for the updated function.

* Changed matching to allow for trailing encoding.
* Added a test case for the updated function.
@ravern
Copy link

ravern commented Jan 24, 2018

+1

Had the same issue with this while using gores package.

Why didn't I check the issues earlier... Spent the last hour trying to figure out why Postman was displaying base64 text.

@tj
Copy link
Member

tj commented Jan 25, 2018

lgtm thanks!

@tj tj merged commit 94cc84b into apex:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants