Spell Checker #80
Merged
Spell Checker #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JPJPJPOPOP
commented
Jan 7, 2018
JPJPJPOPOP
commented
- Deconflicts SpellChecker Handler #59
- Adds streamparser as a submodule
JPJPJPOPOP
force-pushed
the
master
branch
2 times, most recently
from
16c83bd
to
ac2cbda
Compare
|
We need to ignore streamparser. Modifying the Travis mypy command similarly should work: python/mypy#626 (comment) |
sushain97
requested changes
Jan 7, 2018
modeSearch.py
Outdated
| 'tagger': re.compile(r'(({0}(-{0})?)-tagger)\.mode'.format(lang_code)) | ||
| 'tagger': re.compile(r'(({0}(-{0})?)-tagger)\.mode'.format(lang_code)), | ||
| 'spell': re.compile(r'(({0}(-{0})?)-spell)\.mode'.format(lang_code)), | ||
| 'tokenise': re.compile(r'(({0}(-{0})?)-tokenise)\.mode'.format(lang_code)) |
servlet.py
Outdated
| if line.count('Corrections for'): | ||
| foundSugg = True | ||
| continue | ||
| if foundSugg and ' ' in line: |
There was a problem hiding this comment.
In think it's much clear if this and below are \t
servlet.py
Outdated
|
|
||
| result = yield translation.translateSimple(token.wordform, commands) | ||
| foundSugg = False | ||
| for line in result.split('\n'): |
servlet.py
Outdated
|
|
||
| self.sendResponse(units) | ||
| else: | ||
| logging.info('Spellchecker not working') |
There was a problem hiding this comment.
why is this bad?? they input a wrong pair, right?
JPJPJPOPOP
commented
Jan 7, 2018
servlet.py
Outdated
| @@ -1440,7 +1485,8 @@ def apply_config(args, apySection): | |||
| (r'/identifyLang', IdentifyLangHandler), | |||
| (r'/getLocale', GetLocaleHandler), | |||
| (r'/pipedebug', PipeDebugHandler), | |||
| (r'/suggest', SuggestionHandler) | |||
| (r'/suggest', SuggestionHandler), | |||
| (r'/speller', SpellerHandler) | |||
|
Can you merge in changes from master? I'd like to test this locally. |
sushain97
reviewed
Jan 8, 2018
servlet.py
Outdated
|
|
||
| self.sendResponse(units) | ||
| else: | ||
| self.send_error(404, explanation="{} on spellchecker mode: {}".format('Error 404', 'Mode not installed')) |
There was a problem hiding this comment.
This is kind of an awful error message. "Spelling mode kaz" not installed" e.g. would be far better.
|
Hm... something seems suspect. |
|
@sushain97, is there a speller mode for oci? |
|
Yes.
…On Jan 8, 2018 3:27 PM, "Jonathan Washington" ***@***.***> wrote:
@sushain97 <https://github.com/sushain97>, is there a speller mode for
oci?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEBEfjfIIyLDwKiNhtQHft4aJWqINA67ks5tIohVgaJpZM4RVkLR>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.