fix: align pitr backup retention with cluster retentionPeriod #8297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8297 +/- ##
==========================================
- Coverage 61.35% 61.12% -0.24%
==========================================
Files 350 350
Lines 41162 41164 +2
==========================================
- Hits 25257 25162 -95
- Misses 13611 13711 +100
+ Partials 2294 2291 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ldming
approved these changes
Oct 18, 2024
zjx20
reviewed
Oct 18, 2024
wangyelei
reviewed
Oct 18, 2024
| @@ -635,6 +635,9 @@ func (r *backupPolicyBuilder) mergeClusterBackup( | |||
| if as.Spec.BackupType == dpv1alpha1.BackupTypeContinuous && backup.PITREnabled != nil && !hasSyncPITRMethod { | |||
| // auto-sync the first continuous backup for the 'pirtEnable' option. | |||
| backupSchedule.Spec.Schedules[i].Enabled = backup.PITREnabled | |||
| if backup.RetentionPeriod.String() != "" { | |||
| backupSchedule.Spec.Schedules[i].RetentionPeriod = backup.RetentionPeriod | |||
There was a problem hiding this comment.
pitr retention period needs greater than full backup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
align pitr backup retention with cluster retentionPeriod in backup schedule