Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup the APIs pkg deps and keep them compact #8244

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Oct 9, 2024

resolve #7551

The dependent pkgs defined by KB:

  • github.com/apecloud/kubeblocks/apis/apps/v1
  • github.com/apecloud/kubeblocks/apis/apps/v1alpha1
  • github.com/apecloud/kubeblocks/apis/apps/v1beta1
  • github.com/apecloud/kubeblocks/apis/dataprotection/v1alpha1
  • github.com/apecloud/kubeblocks/apis/workloads/v1
  • github.com/apecloud/kubeblocks/apis/workloads/v1alpha1
  • github.com/apecloud/kubeblocks/pkg/constant
  • github.com/apecloud/kubeblocks/pkg/viperx

@leon-inf leon-inf requested review from ldming and a team as code owners October 9, 2024 02:23
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.37%. Comparing base (708cb8d) to head (76b8236).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8244      +/-   ##
==========================================
+ Coverage   61.18%   61.37%   +0.18%     
==========================================
  Files         348      349       +1     
  Lines       40268    40282      +14     
==========================================
+ Hits        24639    24722      +83     
+ Misses      13385    13334      -51     
+ Partials     2244     2226      -18     
Flag Coverage Δ
unittests 61.37% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf added this to the Release 1.0.0 milestone Oct 9, 2024
Copy link
Contributor

@zjx20 zjx20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to drop the viperx package as well.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 9, 2024
@leon-inf leon-inf merged commit 3111c64 into main Oct 9, 2024
44 checks passed
@leon-inf leon-inf deleted the support/api-pkg-dependencis branch October 9, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Extract the Schema of the API types from Kubeblocks into a separate Go package
4 participants