Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of golang.org/x/exp/{constraints,slices} modules #8239

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

zjx20
Copy link
Contributor

@zjx20 zjx20 commented Oct 8, 2024

Since Go 1.21, these modules were moved into the standard library. However, we can't remove golang.org/x/exp/maps yet, as the standard library doesn't provide the Keys() and Values() methods.

ref links:

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.30%. Comparing base (c65ed8c) to head (1eb7572).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ntrollers/apps/configuration/reconfigure_policy.go 0.00% 3 Missing ⚠️
...ollers/dataprotection/log_collection_controller.go 0.00% 2 Missing ⚠️
controllers/extensions/addon_controller_stages.go 0.00% 1 Missing and 1 partial ⚠️
...llers/apps/configuration/rolling_upgrade_policy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8239      +/-   ##
==========================================
- Coverage   61.36%   61.30%   -0.06%     
==========================================
  Files         349      349              
  Lines       40290    40280      -10     
==========================================
- Hits        24722    24692      -30     
- Misses      13338    13355      +17     
- Partials     2230     2233       +3     
Flag Coverage Δ
unittests 61.30% <20.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 8, 2024
@zjx20 zjx20 merged commit 5dfe1c5 into main Oct 8, 2024
38 checks passed
@zjx20 zjx20 deleted the support/remove-x-exp branch October 8, 2024 06:46
@github-actions github-actions bot added this to the Release 0.8.5 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants