-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove lorry and built-in action handler #7964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into support/integrate-with-kbagent
…ltin-action-handler
leon-inf
requested review from
heng4fun,
free6om,
wangyelei,
Y-Rookie and
weicao
as code owners
August 13, 2024 10:32
…ltin-action-handler
weicao
reviewed
Aug 14, 2024
} | ||
return jobs, nil | ||
} | ||
// func getTargetService(reqCtx intctrlutil.RequestCtx, cli client.Client, clusterObjectKey client.ObjectKey, componentName string) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weicao
approved these changes
Aug 14, 2024
leon-inf
force-pushed
the
support/remove-builtin-action-handler
branch
from
August 14, 2024 06:47
1c3beea
to
edd62fa
Compare
/approve |
apecloud-bot
approved these changes
Aug 14, 2024
leon-inf
force-pushed
the
support/remove-builtin-action-handler
branch
from
August 14, 2024 07:27
edd62fa
to
92bb075
Compare
/approve |
apecloud-bot
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.