fix: add a user check before creating (#7632)

apecloud · Jun 26, 2024 · 1c80b9c · 1c80b9c
1 parent ab3d419
commit 1c80b9c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/controllers/apps/component_controller_test.go b/controllers/apps/component_controller_test.go
@@ -92,6 +92,7 @@ var mockLorryClient = func(mock func(*lorry.MockClientMockRecorder)) {
 var mockLorryClientDefault = func() {
 	mockLorryClient(func(recorder *lorry.MockClientMockRecorder) {
 		recorder.CreateUser(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
+		recorder.DescribeUser(gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
 		recorder.GrantUserRole(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
 	})
 }

diff --git a/controllers/apps/transformer_component_account_provision.go b/controllers/apps/transformer_component_account_provision.go
@@ -222,6 +222,10 @@ func (t *componentAccountProvisionTransformer) provisionAccount(transCtx *compon
 		return nil
 	}
 
+	userInfo, err := lorryCli.DescribeUser(transCtx, string(username))
+	if err == nil && len(userInfo) != 0 {
+		return nil
+	}
 	// TODO: re-define the role
 	return lorryCli.CreateUser(transCtx.Context, string(username), string(password), string(lorryModel.SuperUserRole))
 }