refactor: split runtime_trace cfg impls and report trace periodically - #546
Draft
gnolong wants to merge 2 commits into
Draft
refactor: split runtime_trace cfg impls and report trace periodically#546gnolong wants to merge 2 commits into
gnolong wants to merge 2 commits into
Conversation
Address post-merge review comments on #530: - Split runtime_trace.rs into per-feature modules (traced/noop) selected at module level, so each method is defined once per implementation instead of interleaving feature/not(feature) variants in one file. - Add RuntimeTraceMonitor to the periodic monitor flush loop: the runtime trace summary is now dumped every pipeline.checkpoint_interval_secs, plus a final dump on shutdown, making it usable for long-running CDC tasks. The finish-time-only dump in start_task is removed since the shutdown flush covers it. - Add a structured snapshot_global() API (always marker-aggregated) and export runtime_trace_* per-marker gauges via Prometheus when both metrics and tracing features are enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.