CD grid variables. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apcraig
requested review from
JFLemieux73,
daveh150,
phil-blain and
rallard77
phil-blain
reviewed
Nov 15, 2021
| if (grid_system == 'CD') then | ||
| call define_hist_field(n_uvele,"uvele","m/s",estr2D, ecstr, & | ||
| call define_hist_field(n_uvele,"uvele","m/s",estr2D, ecstr, & |
There was a problem hiding this comment.
So we are defining the new fields unconditionnally, irrespective of grid_system. I guess that's because the field definition themselves do not take that much memory, so we don't care ?
There was a problem hiding this comment.
The new fields should only be allocated with grid_system == 'CD'. There is some logic in the history mechanism that prevents fields from being accumulated and/or written unless the f_ flag is true. And these extra variables with be set to false unless grid_system='CD'. So it's sort of hidden.
apcraig
pushed a commit
that referenced
this pull request
May 10, 2024
Add standalone build config for gadi supercomputer --------- Co-authored-by: Anton Steketee <anton-seaice@noreply.users.github.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Additional CD grid variables.
dabail10 (D. Bailey)
Later
These are needed internally and for history.