New config #371
Merged
New config #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
M-R-Schaefer
requested changes
Nov 21, 2024
| @@ -13,7 +13,7 @@ ensemble: | |||
| duration: <DURATION> # fs | |||
| n_inner: 100 # compiled innner steps | |||
There was a problem hiding this comment.
should we increase n_inner to like 500 or 1000?
| r_min: 0.5 | ||
| name: bessel | ||
| n_basis: 16 | ||
| r_max: 6.5 |
There was a problem hiding this comment.
rmax 6.5 is rarely needed in my experience. Most of the time 5-6 is fine. I would suggest 5 as a default.
Comment on lines
95
to
98
| emb_lr: 0.01 | ||
| nn_lr: 0.01 | ||
| scale_lr: 0.001 | ||
| shift_lr: 0.05 | ||
| shift_lr: 0.03 |
There was a problem hiding this comment.
I would suggest to lower the lrs by a factor of 10 or so
There was a problem hiding this comment.
LRs this high are rarely stable
M-R-Schaefer
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.