Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly handle routeChangeError #80

Merged
merged 5 commits into from
Aug 16, 2022
Merged

fix: properly handle routeChangeError #80

merged 5 commits into from
Aug 16, 2022

Conversation

imranbarbhuiya
Copy link
Collaborator

@imranbarbhuiya imranbarbhuiya commented Aug 11, 2022 •
edited
Loading

fixes: #78

  • this pr adds nprogress types to main deps so that users gets the typings and autocomplete too.
  • added prettier and changed workflow
  • fixed routeChangeError

@imranbarbhuiya imranbarbhuiya requested a review from apal21 August 11, 2022 14:29
@apal21
Copy link
Owner

apal21 commented Aug 11, 2022

Hey @imranbarbhuiya, please increase the "version" in package.json once it's ready for merging.

@imranbarbhuiya
Copy link
Collaborator Author

Hey @imranbarbhuiya, please increase the "version" in package.json once it's ready for merging.

Done.

@apal21 apal21 merged commit 000b0e9 into master Aug 16, 2022
@imranbarbhuiya imranbarbhuiya deleted the fix/gh-78 branch August 16, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apal21 apal21 apal21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The showOnShallow option gets ignored during shallow routing
2 participants
@imranbarbhuiya @apal21